Added from and to parameters to top N queries to specify time range #8132
Conversation
Signed-off-by: Emily Guo <[email protected]>
LilyCaroline17
requested review from
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
I'm assuming that this is part of 2.17 so adding the 2.17 label. |
kolchfa-aws
added
v2.17.0
release-notes
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Emily Guo <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Emily Guo <[email protected]>
|
Thank you! Applying "Done but waiting to merge" label to put this in the 2.17 editorial queue starting 9/11. This PR will be merged before the release. |
kolchfa-aws
added
the
6 - Done but waiting to merge
|
@kolchfa-aws Let's not merge this one in 2.17, since we still need some time to review the underlying PR: opensearch-project/query-insights#84 and we might skip it for 2.17. |
|
@ansjcy Sure, I'll put it on hold for now. |
kolchfa-aws
added
On hold
and removed
6 - Done but waiting to merge
|
@ansjcy should we mark this for 2.18 if ew're not ready with the feature merge for 2.17 ? |
There was a problem hiding this comment.
@kolchfa-aws @LilyCaroline17 Just one minor change. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
|
@ansjcy Looks like the code is merged and backported to 2.x so this made it to 2.17. Removing the "on hold" label. |
|
We are planing to ship this for 2.18 - as we merged the corresponding change into 2.x but didn't backport it into 2.17. Let's change the label to 2.18. |
natebower
added
6 - Done but waiting to merge
Signed-off-by: kolchfa-aws <[email protected]>
…pensearch-project#8132) * Added from and to parameters to top N queries to specify time range Signed-off-by: Emily Guo <[email protected]> * Update _observing-your-data/query-insights/top-n-queries.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Emily Guo <[email protected]> * Update _observing-your-data/query-insights/top-n-queries.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Emily Guo <[email protected]> * Update _observing-your-data/query-insights/top-n-queries.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Emily Guo <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Eric Pugh <[email protected]>
Description
Added from and to parameters to documentation for top N queries
References PR: opensearch-project/query-insights#84
Issues PR: opensearch-project/query-insights#12
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.